Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Configuration COM API for export #3787

Merged
merged 15 commits into from
Oct 25, 2023
Merged

Extend Configuration COM API for export #3787

merged 15 commits into from
Oct 25, 2023

Conversation

florelis
Copy link
Member

@florelis florelis commented Oct 19, 2023 •
edited by microsoft-github-policy-service bot
Loading

This extends the Configuration COM API for the "export" scenario. Most of the changes follow the same pattern as for Get, except that I did not add a new Intent to the API.

  • Extended the interface for the configuration unit processor to be able to export
  • Implemented all the plumbing between the unit processor and the actual invoke of the dsc resource export, which is currently marked as not supported.
  • Added some unit tests for export; this tests only the plumbing as there is no new functionality added yet
Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner October 19, 2023 00:09
JohnMcPMS
JohnMcPMS reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the front end API surface for callers to operate on. Is it coming in a different PR?

@florelis
Copy link
Member Author

This is missing the front end API surface for callers to operate on. Is it coming in a different PR?

I knew I had to be missing something... Added.

@florelis florelis requested a review from JohnMcPMS October 23, 2023 23:06
@florelis
Add custom error
15b5349
@florelis
Add test
935c770
@florelis
;
077a191
@florelis
Merge branch 'master' into exportApi
db6eeeb 
# Conflicts:
#	src/AppInstallerSharedLib/Errors.cpp
#	src/AppInstallerSharedLib/Public/AppInstallerErrors.h
JohnMcPMS
JohnMcPMS previously approved these changes Oct 25, 2023
View reviewed changes
@florelis florelis merged commit 9f3511b into microsoft:master Oct 25, 2023
8 checks passed
@florelis florelis deleted the exportApi branch October 25, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnMcPMS JohnMcPMS JohnMcPMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florelis @JohnMcPMS