Adding the client code for supporting experiments #5034
Conversation
microsoft-github-policy-service
bot
added
the
Issue-Feature
| @@ -77,6 +80,19 @@ namespace AppInstaller::Logging | |||
| return "unknown"sv; | |||
| } | |||
| } | |||
|
|
|||
| std::string GetExperimentsJson(const std::map<Experiment::Key, ExperimentState>& experiments) | |||
There was a problem hiding this comment.
Please create an ExperimentStateCache so that this code and the lookup can live in Experiment.cpp.
There was a problem hiding this comment.
Still feel this should be done.
doc/admx/DesktopAppInstaller.admx
Outdated
There was a problem hiding this comment.
I imagine there is already a policy to disable experimentation across Windows as a whole. I found AllowExperimentation but I'm not sure if it does what I think.
If there is such a policy, I think we would be better off not having our own and just pointing people to that one. If somebody disables it system-wide, then our policy won't do anything because the infrastructure we use will be disabled. The only case where it would be useful to have both is if somebody wants to have experimentation in Windows as a whole, but not on winget specifically, which I don't think is a common scenario
| @@ -25,6 +25,12 @@ If you disable this setting, users will not be able to change settings for the W | |||
| If you enable or do not configure this setting, users will be able to enable experimental features for the Windows Package Manager. | |||
|
|
|||
| If you disable this setting, users will not be able to enable experimental features for the Windows Package Manager.</string> | |||
| <string id="EnableExperiments">Enable Windows Package Manager Experiments</string> | |||
There was a problem hiding this comment.
I would suggest the policy be called "Allow" instead of "Enable" even if it is not consistent with the other policies.
To me, "Enable" means that the experiments will be turned on but that's not what happens. What happens is that experiments may be turned on depending on the control/treatment groups; which is better described by "Allow"
It probably should also mention that they are Microsoft-run experiments for new features/changes
There was a problem hiding this comment.
I remember discussing this with Roy offline last Wednesday, but tagging him here in case he wants to add further information. Correct me if I am wrong Roy, but we will keep this Enable instead to align with the other policies.
CC: @RDMacLachlan
… user/amelbawa/experiment
|
/az run |
Adding the client-side code for supporting running experiments in winget-cli.
Group policy:
User settings:
"experimentation": Enable the user to control whether or not an experiment should run or not.
I have signed the Contributor License Agreement.
This pull request is related to an issue.
Microsoft Reviewers: Open in CodeFlow