Windows setting language

[Gijsreyn]

• I have signed the Contributor License Agreement.
• This pull request is related to an issue.

---

Addresses issue #34 and #92. Only the module this time.

Microsoft Reviewers: Open in CodeFlow

[Gijsreyn]

@stephengillie Opened up this one. Hope you don't mind the docs for the module here.

[Gijsreyn]

@ryfu-msft You can put this on hold. I'm seeing some strange behaviours with the relevant modules used to set language, plus a bug found on Windows PowerShell: PowerShell/PowerShellModuleCoverage#18.

@denelon I might need your help, but I'll test thoroughly first and let you know.

[denelon]

@Gijsreyn I converted this to a draft PR until you're ready for review/merge.

[stephengillie]

Apologies for my absent repsonse - I've been too busy maintaining the winget-pkgs repo, to be able to review this and provide feedback with constructive value.

[Gijsreyn]

Apologies for my absent repsonse - I've been too busy maintaining the winget-pkgs repo, to be able to review this and provide feedback with constructive value.

Thanks for letting me know and no worries. We can't do everything at the same time.

[Gijsreyn]

@ryfu-msft I know you're also quite busy, but if you have time to recheck this one, I would appreciate it. I incorporated as much feedback as you gave me earlier. If I've missed something, then I apologize. I have rewritten many parts and tested the logic on a fresh box. Many thanks for considering my request.

P.S. I'm putting other settings regarding the region on hold. That way, the PR doesn't get that big

[ryfu-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ryfu-msft]

The implementation looks good to me! I think the tests are showing that you have some module dependency issues as well as a couple lines to fix in the tests.

[Gijsreyn]

The implementation looks good to me! I think the tests are showing that you have some module dependency issues as well as a couple lines to fix in the tests.

Fixed up the tests. I think I was a bit to fast. Added the import module statement now. Can you give it another go?

[ryfu-msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Gijsreyn]

@ryfu-msft This is a bit out of my league. Clearly, the image that is being used does not have the LanguagePackmanagement built-in. I cannot find anywhere to install it. My best bet would be to either add it directly to the repository, which is quite dirty, or mock the Pester tests. Any other suggestions are welcome.

EDIT 2: After asking the question on azure-pipelines-agent repository, I found out this module is only for clients.

[ryfu-msft]

@ryfu-msft This is a bit out of my league. Clearly, the image that is being used does not have the LanguagePackmanagement built-in. I cannot find anywhere to install it. My best bet would be to either add it directly to the repository, which is quite dirty, or mock the Pester tests. Any other suggestions are welcome.

EDIT 2: After asking the question on azure-pipelines-agent repository, I found out this module is only for clients.

Ah I see, if that is the case then you can try mocking the result of the function that uses the LanguagePackManagement so that it doesn't get invoked. The other option is the remove parts of the tests that require LanguagePackageManagement. We will attempt to have as much coverage as we can since this this is not supported on server builds.

[Gijsreyn]

@ryfu-msft This is a bit out of my league. Clearly, the image that is being used does not have the LanguagePackmanagement built-in. I cannot find anywhere to install it. My best bet would be to either add it directly to the repository, which is quite dirty, or mock the Pester tests. Any other suggestions are welcome.
EDIT 2: After asking the question on azure-pipelines-agent repository, I found out this module is only for clients.

Ah I see, if that is the case then you can try mocking the result of the function that uses the LanguagePackManagement so that it doesn't get invoked. The other option is the remove parts of the tests that require LanguagePackageManagement. We will attempt to have as much coverage as we can since this this is not supported on server builds.

Okay, after trying multiple approaches, I will give this one up. The reasoning being is the following:

• When mocking, it tells me that the cmdlet is not available
• Other errors that are thrown are related to a bug; see image below

The only thing that remains is a different OS, which changes the Azure Pipelines. I have commented out all tests, expect the validation of DSC resources. Sorry Ryan. If you have any more suggestions, they are welcome, but I don't see anyway currently to get it working on the hosted agents.

P.S. The code I tried (thanks to Trenly):

InModuleScope -ModuleName Microsoft.Windows.Setting.Language {
    Describe 'Language' {
        BeforeAll {
            Mock Get-Language { return @{Language = 'en-GB'; } }
            Mock Install-Language { return $null }
        }
 
        $script:LanguageResource = [Language]::new()
 
        Context 'Install Language' -Tag 'Set' {
            It 'Should install a language' {
                $LanguageResource.LanguageId = 'en-GB'
                { $LanguageResource.Set() } | Should -Not -Throw
            }
        }

        Context 'Uninstall Language' -Tag 'Set' {
            It 'Should uninstall a language' {
                $LanguageResource.LanguageId = 'en-GB'
                $LanguageResource.Exist = $false
                { $LanguageResource.Set() } | Should -Not -Throw
            }
        }
 
    }
}