Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup on QA tests #124

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 7, 2024


Addresses issue #123

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Nov 7, 2024

Hey @denelon, @ryfu-msft and @Trenly,

I thought of giving this one a shot to improve the quality in this repository. This might annoy people in first, but in the end it is for the betterment for everyone. I know Ryan you have been working on #56, but I have also included it in here.

The pull request is not finished yet, but when you have some time, you mind taking a glimpse at this one and share your thoughts? Thanks in advance.

@Gijsreyn Gijsreyn force-pushed the module-quality-tests branch from d709c71 to ca1d97a Compare November 14, 2024 04:11

This comment has been minimized.

@denelon denelon requested a review from ryfu-msft November 14, 2024 17:52
@Gijsreyn Gijsreyn force-pushed the module-quality-tests branch from ca1d97a to f592f3b Compare December 7, 2024 08:43
Copy link

github-actions bot commented Dec 7, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

pssa

These words are not needed and should be removed markdownlint VGpu

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:Gijsreyn/winget-dsc.git repository
on the module-quality-tests branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/12211501911/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant