Fix path search #135
Fix path search #135
Conversation
microsoft-github-policy-service
bot
added
the
Changes-Requested
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
Gijsreyn
force-pushed
the
fix-vscode-search-path
branch
from
7cc1632 to
d411df7
Compare
microsoft-github-policy-service
bot
removed
Changes-Requested
|
Thanks for the comments @ryfu-msft . I have rewritten the logic and grabbed most of the old stuff from you. Looking at the code from: https://github.com/desktop/desktop/blob/development/app/src/lib/editors/win32.ts, I included the WOW6432Node path as well. Let me know what you think. On a 64-bit system, I'm getting this:
|
| foreach ($hive in $registryHive) { | ||
| foreach ($key in $registryKeys) { | ||
| Write-Verbose -Message ("Searching path '{0}' with key '{1}'" -f $hive, $key) | ||
| $installLocation = TryGetRegistryValue -Key "$hive\$key" -Property 'InstallLocation' | ||
| if ($installLocation) { | ||
| $cmdPath = $Insiders ? 'bin\code-insiders.cmd' : 'bin\code.cmd' | ||
| return Join-Path $installLocation $cmdPath | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not a fan of iterating through registry key entries until we find a match. Based on the parameters provided (scope, isInsiders) for the DSC resource, it should be deterministic as to where the VSCode should be installed.
There was a problem hiding this comment.
Nor am I buddy. The thing is, DSC doesn't know the scope; WinGet does. We don't have a property for it. It is only 3 locations it iterates through, and if it finds one, it returns it. What do you think? Can we push this through, or do you have another suggestion for it?
microsoft-github-policy-service
bot
added
Changes-Requested
…winget-dsc into fix-vscode-search-path
microsoft-github-policy-service
bot
removed
Changes-Requested
Addresses issue #105
Microsoft Reviewers: Open in CodeFlow