-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix configuration file #138
Conversation
@Trenly and @ryfu-msft I think there was one small step missing in the configuration file inside this repository. This should fix it. |
The configuration was built presuming the user was already operating inside the cloned repository, as would be the most common workflow when using DevHome |
That was my assumption as well, but for fresh boxes, perhaps it is better to include it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd have to agree with Trenly here as well. In my mind the most common workflow would be to start by cloning this repo, then running winget configure
on the configuration file. Your change will cause it to clone the same repo again. I think it is probably best to leave out the git clone part as that is not really needed within the context of this repo.
Thanks for the sharing and interesting thoughts. I would have assumed the GitClone resource would test for it. If it is already present, it applies the configuration successfully without additional cloning (depending on where the user executes it, of course). Regardless, I have removed the GitClone for now. I have fixed up the cloning because it was pointing towards winget-pkgs. I have added the PowerShell requirement. |
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Addresses issue #137
Microsoft Reviewers: Open in CodeFlow