-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation effects #48
Draft
stephengillie
wants to merge
37
commits into
microsoft:main
Choose a base branch
from
stephengillie:AnimationEffects
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stephengillie
commented
Jul 23, 2024
- I have signed the Contributor License Agreement.
- This pull request is related to an issue.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
requested changes
Jul 24, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
tests/Microsoft.Windows.Developer/Microsoft.Windows.Developer.Tests.ps1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
reviewed
Aug 2, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
…ndows.Setting.Accessibility.psm1 Co-authored-by: Ryan <[email protected]>
ryfu-msft
reviewed
Aug 2, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
ryfu-msft
reviewed
Aug 2, 2024
resources/Microsoft.Windows.Setting.Accessibility/Microsoft.Windows.Setting.Accessibility.psm1
Outdated
Show resolved
Hide resolved
ryfu-msft
reviewed
Aug 2, 2024
tests/Microsoft.Windows.Settings.Accessiblity/Microsoft.Windows.Settings.Accessiblity.Tests.ps1
Outdated
Show resolved
Hide resolved
ryfu-msft
reviewed
Aug 2, 2024
tests/Microsoft.Windows.Settings.Accessiblity/Microsoft.Windows.Settings.Accessiblity.Tests.ps1
Outdated
Show resolved
Hide resolved
…if none of the conditions were satisfied."
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
SInce this set of settings is relatively unique compared to the other PRs currently open, I'm going to wait on integrating upstream changes until the correct implementation is found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.