Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use appropriate zip fields for Cilium.Hubble #189500

Closed
wants to merge 3 commits into from

Conversation

nebula-it
Copy link
Contributor

@nebula-it nebula-it commented Nov 7, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 7, 2024
Co-authored-by: Muhammad Danish <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Nov 7, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Nov 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 7, 2024
@nebula-it
Copy link
Contributor Author

Hey @mdanish-kh, Any idea on the validation failure?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 7, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335140
2024-11-07 12:39:04.278 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerCommonCore\Archive.cpp(33)\WindowsPackageManager.dll!00007FFED75C413B: (caller: 00007FFED753EBB5) ReturnHr(1) tid(d38) 80004005 Unspecified error
2024-11-07 12:39:04.280 [CLI ] Failed to extract archive with code -2147467259

Automated error analysis suggests -1978335140 may mean Failed to extract archive. Does the InstallerUrl actually end in .zip - or does it have a different extension?

Automated error analysis suggests 80004005 may mean Resource missing

(Automated response - build 897.)

@nebula-it
Copy link
Contributor Author

Installers have .tar.gz extension as you can see here

@stephengillie
Copy link
Collaborator

The package manager first downloads the file to a temporary location, with a temporary name, then renames the file and moves it to its target location. When InstallerType: zip is used, the existing file extension is clobbered and replaced with .zip. Then ZIP extraction fails, causing the exit code -1978335140.

Usually this happens with .exe installers being renamed to .zip. But here, it appears to be renaming a .tar.gz file to .zip. A workaround to get this working locally is to change the package manager setting archiveExtractionMethod from shellApi to tar. But this isn't currently supported in the pipelines:

@nebula-it
Copy link
Contributor Author

Thank you for digging, I guess we just have to wait till it is implemented?
Or we can continue using the InstallerType: portable as it was used previously and undo changes in this PR.

@stephengillie
Copy link
Collaborator

Yes, we'll have to wait for the feature to be implemented before we can use it.

There's nothing to undo, as this PR hasn't been merged yet. Feel free to close the PR if you do not want to make this change.

nebula-it added a commit to nebula-it/winget-pkgs-automation that referenced this pull request Nov 23, 2024
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Installation-Error Error installing application labels Nov 29, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Nov 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 29, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application labels Dec 1, 2024
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Dec 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 1, 2024
@nebula-it
Copy link
Contributor Author

Hey @ItzLevvie, As noted here we are waiting on winget to implement this.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 1, 2024
@pl4nty
Copy link

pl4nty commented Dec 3, 2024

Can we remove v1.16.3 too? InstallerType: portable just renames the .tar.gz to .exe, so it can't actually be executed

@ItzLevvie
Copy link
Contributor

[Policy] Blocking-Issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 6, 2024
@denelon denelon closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants