Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Devicetree compiler version 1.6.1 #202965

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlescufi
Copy link

@carlescufi carlescufi commented Dec 28, 2024

This adds the Devicetree compiler (dtc) version 1.6.1.

Replaces previous attempt in #114001

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

This adds the Devicetree compiler (dtc) version 1.6.1.

Signed-off-by: Carles Cufi <[email protected]>
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Dec 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 28, 2024
@carlescufi
Copy link
Author

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

winget install --manifest <path> seems to work fine locally for me. The logs do not seem to show any useful information.

@stephengillie @Trenly @mdanish-kh pinging you since you commented on this PR's predecessor, any clues as to what is wrong?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 28, 2024
@Trenly
Copy link
Contributor

Trenly commented Dec 28, 2024

@carlescufi - If you go to the artifacts of the pipeline run, you can download additional logs from the check which aren't able to be exposed to the Azure Pipelines console. In these logs I see

2024-12-28 07:41:46.975 [FAIL] Installer failed security check. Url: https://github.com/carlescufi/winget-packages/raw/refs/heads/main/packages/dtc/1.6.1/dtc-msys2-1.6.1-x86_64.zip Result: 0x80004005
2024-12-28 07:41:46.975 [CLI ] Terminating context: 0x8a15002d at D:\a\_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\DownloadFlow.cpp:1e6

This error usually means that it isn't a URL that Windows Defender Smart Screen is aware of. Typically, these errors resolve themselves in a day or two after SmartScreen finishes scanning the URL. I believe Stephen's automation will attempt a retry after a day automatically, but if not, feel free to simply close and re-open this PR to kick off a new validation run

@carlescufi
Copy link
Author

This error usually means that it isn't a URL that Windows Defender Smart Screen is aware of. Typically, these errors resolve themselves in a day or two after SmartScreen finishes scanning the URL. I believe Stephen's automation will attempt a retry after a day automatically, but if not, feel free to simply close and re-open this PR to kick off a new validation run

I see, thank you @Trenly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants