-
Notifications
You must be signed in to change notification settings - Fork 31
Made Install-Dependencies much faster by only installing missing requirements #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit df85d15: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
df85d15
to
e090cee
Compare
Learn Build status updates of commit e090cee: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Learn Build status updates of commit 4953171: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 2e1c8dc: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 0f74281: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7e83d2c: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 60bf7fb: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7343254: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e99a74f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Learn Build status updates of commit f699430: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit e3368ff:
|
File | Status | Preview URL | Details |
---|---|---|---|
Details | |||
module/docfx.json | Details | ||
build/Install-Dependencies.ps1 | ✅Succeeded |
- Line 0, Column 0: [Warning: MAML2Yaml_Directory_NotFound]
Directory can't be found: entra-powershell-v1.0
- Line 0, Column 0: [Warning: MAML2Yaml_Directory_NotFound]
Directory can't be found: entra-powershell-beta
- Line 0, Column 0: [Warning: not-failed]
Invalid value for 'open_to_public_contributors': 'True'.
module/docfx.json
- Line 27, Column 30: [Warning: not-failed]
Invalid value for 'extendBreadcrumb': 'True'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
Learn Build status updates of commit 855d81b: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit e7eab97: ✅ Validation status: passed
For more details, please refer to the build report. |
Learn Build status updates of commit 6017370: ✅ Validation status: passed
For more details, please refer to the build report. |
6017370
to
3c9f16e
Compare
Learn Build status updates of commit 3c9f16e: ✅ Validation status: passed
For more details, please refer to the build report. |
…e is specified. Add version checks and error handling. Update/fix comments. Remove unused Common-Functions import. Update text case to be consistent. Refactor Install-Dependencies to only install or update as needed unless Force is used. Add version checks and error handling. Update/fix comments. Made much faster by only installing missing dependencies unless -Force is specified.
3c9f16e
to
8ea8211
Compare
Learn Build status updates of commit 8ea8211: ✅ Validation status: passed
For more details, please refer to the build report. |
The current build script installs all required module dependencies, even if they are already installed. This only installs them if they are missing or not using the required version.
The
-Force
switch follows the original behavior of installing all modules, even if they are already installed.This PR addresses #893 (Make Install-Dependencies faster by only installing what is needed). It's a low priority "nice to have" feature that improves the local build experience.