Skip to content

Made Install-Dependencies much faster by only installing missing requirements #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SamErde
Copy link
Collaborator

@SamErde SamErde commented Jul 5, 2024

The current build script installs all required module dependencies, even if they are already installed. This only installs them if they are missing or not using the required version.

The -Force switch follows the original behavior of installing all modules, even if they are already installed.

This PR addresses #893 (Make Install-Dependencies faster by only installing what is needed). It's a low priority "nice to have" feature that improves the local build experience.

@SamErde SamErde requested a review from a team as a code owner July 5, 2024 17:34
Copy link

Learn Build status updates of commit df85d15:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc force-pushed the se-Build-Install-Dependencies branch from df85d15 to e090cee Compare July 9, 2024 12:58
Copy link

Learn Build status updates of commit e090cee:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@KenitoInc KenitoInc added the Ready For Review The PR Ready for Review label Jul 9, 2024
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

Learn Build status updates of commit 4953171:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 2e1c8dc:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 0f74281:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7e83d2c:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 60bf7fb:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7343254:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e99a74f:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@SteveMutungi254 SteveMutungi254 added the P0 Highest priority label Jan 16, 2025
Copy link
Contributor

@SteveMutungi254 SteveMutungi254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

Learn Build status updates of commit f699430:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit e3368ff:

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details
module/docfx.json ⚠️Warning Details
build/Install-Dependencies.ps1 ✅Succeeded

  • Line 0, Column 0: [Warning: MAML2Yaml_Directory_NotFound] Directory can't be found: entra-powershell-v1.0
  • Line 0, Column 0: [Warning: MAML2Yaml_Directory_NotFound] Directory can't be found: entra-powershell-beta
  • Line 0, Column 0: [Warning: not-failed] Invalid value for 'open_to_public_contributors': 'True'.

module/docfx.json

  • Line 27, Column 30: [Warning: not-failed] Invalid value for 'extendBreadcrumb': 'True'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 855d81b:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

@SamErde SamErde marked this pull request as draft June 17, 2025 03:30
Copy link

Learn Build status updates of commit e7eab97:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

Copy link

Learn Build status updates of commit 6017370:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

@SamErde SamErde force-pushed the se-Build-Install-Dependencies branch from 6017370 to 3c9f16e Compare June 17, 2025 14:24
Copy link

Learn Build status updates of commit 3c9f16e:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

…e is specified.

Add version checks and error handling.

Update/fix comments.

Remove unused Common-Functions import.
Update text case to be consistent.

Refactor Install-Dependencies to only install or update as needed unless Force is used.

Add version checks and error handling.

Update/fix comments.

Made much faster by only installing missing dependencies unless -Force is specified.
@SamErde SamErde force-pushed the se-Build-Install-Dependencies branch from 3c9f16e to 8ea8211 Compare June 17, 2025 14:28
Copy link

Learn Build status updates of commit 8ea8211:

✅ Validation status: passed

File Status Preview URL Details
build/Install-Dependencies.ps1 ✅Succeeded

For more details, please refer to the build report.

@SamErde SamErde marked this pull request as ready for review June 17, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Highest priority Ready For Review The PR Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants