Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use resources to validate paths #2812

Merged

Conversation

thewahome
Copy link
Collaborator

Overview

Walking through the resources ensures that we have a working model for the validator to go through. This guarantees that we are working off a known set of resources .
All queries that do not match a known path created by combining segments in the resource tree are marked as invalid which we can validate with certainity

Fixes #2461

Demo

Optional. Screenshots, curl examples, etc.

Notes

The ABNF rules in the ODATA ABNF repository are documentation intended for human readers. They are not intended for generating a ready-to-use URL parser..

Testing Instructions

  • Spin up GE
  • In the Query Bar, write anything after the /v1.0/
  • Notice the messaging about it not being a valid URL

@thewahome thewahome requested a review from a team as a code owner October 2, 2023 14:19
@thewahome thewahome changed the title Fix/improve abnf false positives Fix: improve abnf false positives Oct 2, 2023
@thewahome thewahome marked this pull request as draft October 2, 2023 14:40
@thewahome thewahome marked this pull request as ready for review October 6, 2023 09:15
@thewahome thewahome changed the title Fix: improve abnf false positives Fix: use resources to validate paths Oct 6, 2023
@thewahome thewahome merged commit f680ae9 into fix/autocomplete-validation Oct 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thewahome thewahome deleted the fix/improve-abnf-false-positives branch January 8, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant