Fix The specified child already has a parent. You must call removeVie…

…w() on the child's parent first. #6
microspaze · Apr 2, 2024 · a64a99d · a64a99d
1 parent d90f7e9
commit a64a99d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/RGPopup.Maui/Platforms/Android/Impl/PopupPlatformDroid.cs b/RGPopup.Maui/Platforms/Android/Impl/PopupPlatformDroid.cs
@@ -35,7 +35,7 @@ public event EventHandler OnInitialized
         public Task AddAsync(PopupPage page)
         {
             HandleAccessibilityWorkaround(page, ImportantForAccessibility.NoHideDescendants);
-            
+
             page.Parent = XApplication.Current?.MainPage;
             var pageHandler = page.GetOrCreateHandler<PopupPageHandlerDroid>();
             DecorView?.AddView(pageHandler.PlatformView);
@@ -56,7 +56,8 @@ public Task RemoveAsync(PopupPage page)
                 page.Parent = null;
                 //If manual dispose the view's renderer, but the view is not disposed at the same time, it will crash when repush the view.
                 //renderer.Dispose();
-
+                page.Handler?.DisconnectHandler();
+
                 if (DecorView != null)
                     return PostAsync(DecorView);
             }

diff --git a/RGPopup.Maui/Platforms/MacCatalyst/Impl/PopupPlatformMacOS.cs b/RGPopup.Maui/Platforms/MacCatalyst/Impl/PopupPlatformMacOS.cs
@@ -89,6 +89,7 @@ public async Task RemoveAsync(PopupPage page)
             {
                 var window = viewController.View?.Window;
                 page.Parent = null;
+                page.Handler?.DisconnectHandler();
                 if (window != null)
                 {
                     var rvc = window.RootViewController;

diff --git a/RGPopup.Maui/Platforms/Windows/Impl/PopupPlatformWindows.cs b/RGPopup.Maui/Platforms/Windows/Impl/PopupPlatformWindows.cs
@@ -65,6 +65,7 @@ public async Task RemoveAsync(PopupPage page)
             {
                 popup.IsOpen = false;
                 page.Parent = null;
+                page.Handler?.DisconnectHandler();
             }
 
             await Task.Delay(5);

diff --git a/RGPopup.Maui/Platforms/iOS/Impl/PopupPlatformIos.cs b/RGPopup.Maui/Platforms/iOS/Impl/PopupPlatformIos.cs
@@ -86,6 +86,7 @@ public async Task RemoveAsync(PopupPage page)
             {
                 var window = viewController.View?.Window;
                 page.Parent = null;
+                page.Handler?.DisconnectHandler();
                 if (window != null)
                 {
                     var rvc = window.RootViewController;