Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newer PHP versions for tests, update dependencies #1

Merged
merged 3 commits into from
Mar 8, 2025

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Mar 7, 2025

No description provided.

@oscarotero
Copy link
Member

Thank you but the test file uses old dependencies that make the tests to fail.
Can you replace the file content with this other content?: https://github.com/middlewares/request-handler/blob/master/.github/workflows/main.yaml

@mimmi20
Copy link
Contributor Author

mimmi20 commented Mar 8, 2025

Thank you but the test file uses old dependencies that make the tests to fail.

Did you consider to add Dependabot or other tools to keep the dependencies up to date?

@oscarotero
Copy link
Member

Thanks!
Unfortunately, the tests are still failing due laminas version that is not compatible with php 8.4. Can you change it to "laminas/laminas-diactoros": "^2.3 || ^3.0"?

@mimmi20
Copy link
Contributor Author

mimmi20 commented Mar 8, 2025

changed

@oscarotero oscarotero merged commit 1740ec2 into middlewares:master Mar 8, 2025
9 checks passed
@oscarotero
Copy link
Member

It works nice, thank you!

Did you consider to add Dependabot or other tools to keep the dependencies up to date?

Yes I had it but it was a bit anoying (too much noise).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants