Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device): no supported protocol caused high cpu usage #346

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

wuwentao
Copy link
Member

@github-actions github-actions bot added the bug Something isn't working label Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
midealocal/device.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
midealocal/device.py 33.76% <0.00%> (-0.09%) ⬇️

@chemelli74
Copy link
Member

@wuwentao IMHO we should avoid all those sleep around the code and find a proper way to handle the loop

@wuwentao
Copy link
Member Author

wuwentao commented Jan 2, 2025

@wuwentao IMHO we should avoid all those sleep around the code and find a proper way to handle the loop

Thank you very much for you review comments, any good suggestion or solution ?

@chemelli74
Copy link
Member

Will check once back from my trip

@wuwentao wuwentao added this to the v6.0.4 milestone Jan 7, 2025
@wuwentao
Copy link
Member Author

@chemelli74

  1. I will try to merge this PR at first, as I want to publish a new release, we can try to improve it in next release (if you have any good idea and solution for it)

  2. there is more PRs change need to verify with user device and debug log, they don't know how to manual test and update source code, in addition, these PRs code should NOT the finally version, still need some changes with user device test, especially the same type with different submodule, so I will disable codecov checks in github actions, and merge these PRs. as most of these PR required unit test to pass, but we should verify the code logic with user device at first, and NOT unttest, we can accept bug and error in code, and try to fix it in next release.

thanks!

@wuwentao wuwentao merged commit 013aee4 into main Jan 15, 2025
7 checks passed
@wuwentao wuwentao deleted the no_query branch January 15, 2025 06:52
wuwentao added a commit that referenced this pull request Jan 15, 2025
🤖 I have created a release *beep* *boop*
---


##
[6.1.0](v6.0.3...v6.1.0)
(2025-01-15)


### Features

* **c3:** add disinfect and fix tbh set error
([#340](#340))
([5f5224b](5f5224b))
* **cd:** add water_level and temperature option with customize
lua_protocol
([#345](#345))
([db2fdf0](db2fdf0))
* **cloud:** add plugin download for meiju and smarthome
([#336](#336))
([30de473](30de473))
* **db:** add new attributes for db device
([#329](#329))
([da38007](da38007))
* **dc:** add new attributes for exist dc device
([#330](#330))
([10c15b6](10c15b6))
* **e1:** add new attributes for e1 device
([#337](#337))
([9afa160](9afa160))
* **ed:** add all query msg for 0xED device
([#328](#328))
([30ba082](30ba082))


### Bug Fixes

* fix:
([db2fdf0](db2fdf0))
* **device:** no supported protocol caused high cpu usage
([#346](#346))
([013aee4](013aee4))


### Documentation

* add collected lua scripts
([#331](#331))
([e1a3855](e1a3855))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(AC): AC设备No Query Protocol循环导致High CPU
2 participants