Handle tooltip comments of overlapping annotations #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles the tooltips displaying the comments of overlapping annotations, as long as only one of the annotations that contain the mouse cursor has a tooltip. Before, SpectrogramPlot::getAnnotationComment() would return the comment of the first annotation that contains the mouse cursor, even if such a comment is an empty QString. The empty QString would cause that no tooltip is displayed. Now SpectrogramPlot::getAnnotationComment() only returns non-empty comments. Therefore, if only one annotation with a comment contains the mouse cursor, the tooltip for that comment will be displayed. This still does not handle the case when multiple annotations with comments contain the mouse cursor, since it is not clear what is best to do in this case. For now, SpectrogramPlot::getAnnotationComment() simply returns one of the applicable comments. Signed-off-by: Daniel Estévez <[email protected]>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the tooltips displaying the comments of overlapping annotations, as long as only one of the annotations that contain the mouse cursor has a tooltip.
Before,
SpectrogramPlot::getAnnotationComment()would return the comment of the first annotation that contains the mouse cursor, even if such a comment is an emptyQString. The emptyQStringwould cause that no tooltip is displayed. NowSpectrogramPlot::getAnnotationComment()only returns non-empty comments. Therefore, if only one annotation with a comment contains the mouse cursor, the tooltip for that comment will be displayed.This still does not handle the case when multiple annotations with comments contain the mouse cursor, since it is not clear what is best to do in this case. For now,
SpectrogramPlot::getAnnotationComment()simply returns one of the applicable comments.