rdup-up: handle reversed (-R) rdup dumps #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle reverse dumps by trapping ENOENT and trying to create parent directories, then retrying the operation. If this fails log it and move on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inherent problem with normal dumps: directory a/mtimes don't get reset to the stored value. Reverse dumps suffer no such problem, but rdup-up does not support them as it is.
This is my attempt to support reverse dump in rdup-up, following the logic used when EACCESS is returned. So, in response to an ENOENT error when creating an object, attempt to make the parent path and then try the operation. If this fails log it and move on.
****This relies on dir_parent() not returning the trailing /