Feature/implement webchart sso #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wreiske, I have made the changes to the npm package, Request you to kindly merge the PR. |
horner
requested changes
Oct 25, 2024
| sessionCookie, | ||
| connectTokenRefreshedAt: new Date(), | ||
| expiration: new Date(new Date().getTime() + 5 * 60 * 1000), | ||
| }); |
src/MIEApi.js
Outdated
|
|
||
| const getCookieResponse = await axios.get(`${this.baseUrl}?f=wcrelease&json`, { | ||
| headers: { | ||
| 'User-Agent': 'BlueHive AI (Get x-db_name)', |
There was a problem hiding this comment.
We have a default of mieapi but allow for an override
horner
requested changes
Oct 25, 2024
src/MIEApi.js
Outdated
|
|
||
| const response = await axios.get(refreshUrl, { | ||
| headers: { | ||
| 'User-Agent': 'BlueHive AI (Refresh Connection)', |
There was a problem hiding this comment.
Also, please do not use this user agent. You should call it something like mieapi and possibly include the version string for the NPM version.
There was a problem hiding this comment.
I changed it to mieapi and included the npm version
| if (cachedSession && cachedSession.sessionCookie) { | ||
| const now = new Date(); | ||
| const timeElapsed = now - new Date(cachedSession.connectTokenRefreshedAt); | ||
| if (timeElapsed < 5 * 60 * 1000) { |
There was a problem hiding this comment.
Magic code not linked to the other
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following changes -