Skip volume migration rollback for non storage conversion #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only do a rollback if we are doing a direct storage conversion. Any other type of migration don't sync the data back to the source. Fixed two other issues: - NPE when a source cluster is not found - On a live migration rollback, the skipped volumes where appended endlessly instead of resetting the skipped list everything reconcile. Signed-off-by: Alexander Wels <[email protected]>
dymurray
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only do a rollback if we are doing a direct storage conversion. Any other type of migration don't sync the data back to the source.
Fixed two other issues:
skipped list everything reconcile.