Instead of -new add -mig-xxxx to the end of the new pv names #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support multiple migrations of the same PV we need to add a unique suffix to the end of the PV name when creating new PVs. The new suffix is '-mig-' + 4 character random string of letters. When migrating a PV that already has the suffix, we will remove the suffix and create a new one. In order to support legacy plans and pvs if the suffix is -new we replace -new with -mig-xxxx for the new pv name. relaxed the validation of pvs to only include pvs that are not being skipped in the plan. This allows for the original pv to still exist in the namespace. Signed-off-by: Alexander Wels <[email protected]>
github-actions
bot
added
the
update-operator
|
/cc @dymurray If you could review? |
pranavgaikwad
requested changes
Oct 8, 2024
pranavgaikwad
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support multiple migrations of the same PV we need to add a unique suffix to the end of the PV name when creating new PVs. The new suffix is '-mig-' + 4 character random string of letters. When migrating a PV that already has the suffix, we will remove the suffix and create a new one.
In order to support legacy plans and pvs if the suffix is -new we replace -new with -mig-xxxx for the new pv name.
relaxed the validation of pvs to only include pvs that are not being skipped in the plan. This allows for the original pv to still exist in the namespace.
Goes with migtools/mig-ui#1525 which modifies the UI to properly allow users to select the PVs and get feedback if their selection is valid or not.