Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #89 - Use custom UUID for NAB Object #101

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Oct 14, 2024

  1. Fix for migtools#89 - Use custom UUID for NAB Object

    With this change a new UUID is generated to reference parent/child relationship
    between objects in the Non Admin Controller use cases.
    
    The first consumer of this UUID is a Velero Backup, created when the
    NonAdminBackup object is reconciled.
    
    The NonAdminBackup object generates the NAC UUID and stores it in its
    Status. This prevents users from modifying it. The UUID is later used
    to create the Velero Backup during reconciliation.
    
    While the NAC UUID is currently used as the Velero Backup name, this is
    not required, as the UUID is also stored as a Velero Backup label, which
    is used during the reconcile loop. Usage of NAC UUID as Velero Backup name
    is to easy it's creation.
    
    This PR also includes small changes to fix linting issues of the code,
    as well reworks the tests to properly take advantage of gingko BeforeEach
    function.
    
    Signed-off-by: Michal Pryc <[email protected]>
    mpryc committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2cbd085 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Update function to validate NAC Object Labels

    Improved function to properly validate NAC Object Labels
    Dropped length of Annotation Value validation, as it's not limited
    to 63 or 256 chars.
    
    Signed-off-by: Michal Pryc <[email protected]>
    mpryc committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    97dacc6 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Update custom UUID for NAB Object to reflect Code Review

    Changes to address code review.
    
    Signed-off-by: Michal Pryc <[email protected]>
    mpryc committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ba85bd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Rename function to ListObjectsByLabel

    Renamed function which lists objects by label in a
    specific namespace.
    
    Signed-off-by: Michal Pryc <[email protected]>
    mpryc committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    3cb8cdd View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. NAB reconcile fix to include design diagram and annotation value check

    Change to include:
     - Reworked diagram to include one reconcile entry and multiple states
     - Labels and annotations uses common function to check for the
       name and namespace value length
     - Additional test to cover above scenario.
    
    Signed-off-by: Michal Pryc <[email protected]>
    mpryc committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    e06454e View commit details
    Browse the repository at this point in the history