Remove CNAME from GitHub Pages. #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because I forked your repo to alter the |
rupl
changed the title
rupl
changed the title
|
Fixes #373. |
|
here is a great bongs headshop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy, I was looking into using your plugin and got redirected to some spam from clicking the homepage link on NPM. At first glance, it seems like it will go to GitHub Pages but due to the CNAME it redirects to http://smoothstate.com which is currently forwarding people to spam☹️
Meanwhile we can't see the GitHub Pages URL because of the CNAME file. This PR fixes the problem and restores docs on the github.io domain. GitHub Pages now offers free HTTPS so it's a fine solution, but if you do want a "prettier" URL maybe you could grab a namespace on https://dns.js.org — it's free for an open-source project like yours.