IPC Updates, Detect Spotify on Service Launch, Minor Bugfixes #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fixes init detection. Forgot to add updates to functional declarations in previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please reference: #39 for the specific details. In short, fixes breaking changes and protects against deprecation due to polybar updates 3.6 and 3.7 which break the behavior of this module.
I will continue maintaining this branch specifically for possible PR merge.
I'll continue to unofficially support this package against polybar updates moving forward, at least until I get feedback from the maintainers.
I'm opening issues on the fork. If you end up using the fork please submit issues there:
corigne/polybar-spotify-module
Thanks again to @mihirlad55 for all of your great work on this module! Working on this PR has motivated me to write my own polybar music module, but in a language I'm more unfamiliar with.