[PMON][psud] Fix the repeated NOTICE log message on Chassis platform (s…

…onic-net#529) * [PMON][psud] Fix the repeated NOTICE log message on Chassis platform Signed-off-by: mlok <[email protected]> * Fix the Unit test --------- Signed-off-by: mlok <[email protected]>
mihirpat1 · Sep 12, 2024 · f581c06 · f581c06
1 parent b3189e3
commit f581c06
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/sonic-psud/scripts/psud b/sonic-psud/scripts/psud
@@ -268,6 +268,8 @@ class PsuChassisInfo(logger.Logger):
                                   'PSU supplied power warning: {}W supplied-power less than {}W consumed-power'.format(
                                       self.total_supplied_power, self.total_consumed_power)
                                   )
+        if self.first_run:
+            self.first_run = False
 
         return set_led
 

diff --git a/sonic-psud/tests/test_PsuChassisInfo.py b/sonic-psud/tests/test_PsuChassisInfo.py
@@ -76,14 +76,14 @@ def test_update_master_status(self):
 
         # Test good values while in good state
         ret = chassis_info.update_master_status()
-        assert ret == True
+        assert ret == False
         assert chassis_info.master_status_good == True
 
         # Test unknown total_supplied_power (0.0)
         chassis_info.total_supplied_power = 0.0
         chassis_info.master_status_good = False
         ret = chassis_info.update_master_status()
-        assert ret == True
+        assert ret == False
         assert chassis_info.master_status_good == False
 
         # Test bad values while in good state
@@ -282,6 +282,15 @@ def test_first_run(self):
         assert ret == True
         assert psud.Psu.get_status_master_led() == MockPsu.STATUS_LED_COLOR_RED
 
+        # first time with good power usage
+        chassis_info = psud.PsuChassisInfo(SYSLOG_IDENTIFIER, chassis)
+        chassis_info.total_supplied_power = 510.0
+        chassis_info.total_consumed_power = 350.0
+        ret = chassis_info.update_master_status()
+        assert ret == True
+        assert psud.Psu.get_status_master_led() == MockPsu.STATUS_LED_COLOR_GREEN
+
+        chassis_info = psud.PsuChassisInfo(SYSLOG_IDENTIFIER, chassis)
         chassis_info.total_supplied_power = 510.0
         chassis_info.total_consumed_power = 350.0
         chassis_info.master_status_good = True