Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manga Notes #428

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
2f7db31
Initial markdown render test
imkunet Feb 18, 2024
cd6432a
Add the text editor
imkunet Feb 18, 2024
9cfb52e
Polishing off note editor
imkunet Feb 19, 2024
d374a52
Added tablet notes
imkunet Feb 19, 2024
d2aca57
Make the edit notes button edit directly
imkunet Feb 19, 2024
4d31f83
Added fade transition between states
imkunet Feb 19, 2024
6dede4f
Make cursor jump to end by default
imkunet Feb 19, 2024
80b45ec
Fixed padding
imkunet Feb 19, 2024
378ad99
Impose note editor length limit
imkunet Feb 20, 2024
4a8566f
Fixes to pass relevant testing
imkunet Mar 5, 2024
37e662d
Add migration to add notes to manga
imkunet Sep 19, 2024
2834aa8
Make spotless
imkunet Sep 19, 2024
d5d9fcc
Design revision
imkunet Sep 19, 2024
45e06ee
Design revision 2
imkunet Sep 19, 2024
0c87a7c
Spotless
imkunet Sep 19, 2024
eb030bf
Abandon markdown for rich text
imkunet Sep 20, 2024
4834887
Rename composable from example name
imkunet Sep 20, 2024
70cd477
Reduce char limit, switch encoding
imkunet Sep 20, 2024
b6983fb
Bump richeditor and fix character count
imkunet Jan 19, 2025
2df33f1
Edit strings
imkunet Jan 19, 2025
df646ae
Resolve strange initialization pattern
imkunet Jan 27, 2025
7ce1bf7
Removed note nullity, tidied up model
imkunet Jan 27, 2025
dbc10a0
Changed strings to review recommendation
imkunet Jan 27, 2025
55d4016
Removed unnecessary code modification
imkunet Jan 27, 2025
062adac
Animate out all bumps caused by updating
imkunet Jan 27, 2025
97b4092
Fix characters remaining indicator
imkunet Jan 27, 2025
31042c7
Update domain/src/main/java/tachiyomi/domain/manga/interactor/SetMang…
imkunet Jan 30, 2025
9586543
Update app/src/main/java/eu/kanade/presentation/manga/MangaScreen.kt
imkunet Jan 30, 2025
df0dd5c
Spotless
imkunet Jan 30, 2025
32b639f
Fix awaitSetNotes parameter
imkunet Jan 30, 2025
8f0b459
Put state and model into the screen
imkunet Jan 30, 2025
af1d5ba
Update app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNote…
imkunet Jan 30, 2025
468b9ce
Update app/src/main/java/eu/kanade/tachiyomi/ui/manga/notes/MangaNote…
imkunet Jan 30, 2025
5c36cd3
Cleanup MangaNotesDisplay
imkunet Jan 30, 2025
1b57f7f
Idiomatic padding values on MangaNotesScreen
imkunet Feb 7, 2025
2d5ca0c
More explicit function parameter names
imkunet Feb 7, 2025
b6b0179
Manga notes in CHANGELOG
imkunet Feb 7, 2025
5c2e1cb
Even more consistency in names
imkunet Feb 7, 2025
e5cc465
Change names to suggestion
imkunet Feb 13, 2025
d4ba7b4
Refactor to include the names
imkunet Feb 13, 2025
ffe4ff9
Use lambda reference
imkunet Feb 14, 2025
e2df5f2
Switch to collapsible top bar
imkunet Feb 18, 2025
4046a31
Restore title subtitle AppBar
imkunet Feb 19, 2025
2fe2571
Migrate notes
imkunet Feb 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update domain/src/main/java/tachiyomi/domain/manga/interactor/SetMang…
…aNotes.kt

Co-authored-by: AntsyLich <[email protected]>
imkunet and AntsyLich authored Jan 30, 2025
commit 31042c70daaa389fc1d72b991dc46389c137aaa2
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ class SetMangaNotes(
private val mangaRepository: MangaRepository,
) {

suspend fun awaitSetNotes(manga: Manga, notes: String): Boolean {
suspend fun awaitSetNotes(mangaId: Long, notes: String): Boolean {
return mangaRepository.update(
MangaUpdate(
id = manga.id,