-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clement interpolation #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ools into feat-clement-interpolation
I added parallel tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added Clement interpolation of argitrary UFL built expressions. The interpolant is constructed by precomputing and caching certain averaging operator which is then applied to construct the resulting$CG_1$ (scalar, vector, tensor) function. By running the demos you'll see that the order of convergence of the interpolant is 1.5 in $L^2$ norm (this is tested on a jungle of expressions in 1d, 2d and 3d). You'll also see that the algorithm scales linearly with number of dofs of the interpolant. The tests pass but coverage of the functionality is not 100%. In particular, I have not seen if the code works in parallel. Also, before this is merged, performance of repeated
clement_interpolate
vsClementInterpolant.__call__
should be evaluated. Finally the demos could be made nicer (perhaps). More suggestions?