Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the old components #775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gorzas
Copy link
Contributor

@Gorzas Gorzas commented Sep 5, 2019

Related #774

@ghost
Copy link

ghost commented Sep 5, 2019

There were the following issues with this Pull Request

  • Commit: 04acf23
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ErvinSabic
Copy link

Pls fix the message @Gorzas so this can get merged by @mike-north and people with octane and just use this lol.

@jacobq
Copy link
Collaborator

jacobq commented Aug 11, 2020

Pls fix the message @Gorzas...

FYI if you don't want to wait you can fork his branch and use git rebase to reword the offending commit messages yourself and create a PR that supersedes this one...

@Gorzas Gorzas force-pushed the bugfix/774-deprecate-function branch from 04acf23 to ab2cce5 Compare August 14, 2020 09:52
@Gorzas
Copy link
Contributor Author

Gorzas commented Aug 14, 2020

Can it be merged now?

@chunyinli
Copy link

I'm running into this issue. Is it possible to merge this PR?
If not, @Gorzas were you able to find a work around?

@Gorzas
Copy link
Contributor Author

Gorzas commented Feb 23, 2021

@chunyinli I'm currently working from my own fork. I don't know if the PR needs something else to be merge 😢 .

@chunyinli
Copy link

I ended up forking it as well as I needed the fix quickly. Thanks for the reply tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants