More efficient cache clearing when using Redis store #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardARPANET
force-pushed
the
efficient-cache-clear
branch
from
842dba7 to
3151529
Compare
richardARPANET
commented
Oct 3, 2018
| if namespace is not None: | ||
| redis = self.dict | ||
| keys = tuple(redis.scan_iter('{0}:*'.format(namespace))) | ||
| redis.delete(*keys) |
There was a problem hiding this comment.
without this it will loop over every single cache key and run DEL redis command. with this change it does it in a single command. i found this as i had ~300k keys in my cache and it was just running forever seemingly. now it clears in a second or so.
richardARPANET
force-pushed
the
efficient-cache-clear
branch
3 times, most recently
from
2272630 to
19b5bd5
Compare
richardARPANET
force-pushed
the
efficient-cache-clear
branch
2 times, most recently
from
918c667 to
dd6e88c
Compare
richardARPANET
force-pushed
the
efficient-cache-clear
branch
from
dd6e88c to
7278fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespaceattribute toMemoizer.namespaceparameter toclearmethod of the Redis Store, to enable more efficient clearing.