Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Carbon v3 new method default parameter compatibility #469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daika7ana
Copy link

Takes into account Carbon v3 new default parameter value on the diffInSeconds method.

Carbon v2 method blueprint:

public function diffInSeconds($date = null, $absolute = true)

Carbon v3 method blueprint:

public function diffInSeconds($date = null, bool $absolute = false): float

Fixes failing tests:

public function testModelCacheDoesntInvalidateDuringCooldownPeriod()

@daika7ana daika7ana mentioned this pull request Jun 16, 2024
@mikebronner
Copy link
Owner

Needs to run and pass all tests, for some reason they weren't triggered.

@mikebronner mikebronner self-requested a review September 11, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants