Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added updated Nuget package spec and Nuget readme file #100

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dcneiner
Copy link
Contributor

@dcneiner dcneiner commented Jul 5, 2014

The AmplifyJS NuGet package has been needing to be updated with the latest code for a while. This request adds the nuspec file into Source control (as well as the associated readme) and maps the built output of Amplify to match the existing NuGet structure. The only new addition is the amplify folder with individual components inside. The finished package files look like this:

/content
  /Scripts
    /amplify
       amplify.core.js
       amplify.core.min.js
       amplify.request.js
       amplify.request.min.js
       amplify.store.js
       amplify.store.min.js
    amplify-vsdoc.js
    amplify.js
    amplify.min.js
    GPL-LICENSE.txt
    MIT-LICENSE.txt
    README.txt

After discussing with @elijahmanor I opted to not put the amplify.js and amplify.min.js files in the /amplify directory so those upgrading from an older version of the package wouldn't have trouble with the files moving.

If @jcreamer898 or anyone else with more experience in .NET and NuGet could chime in on this commit, it would be appreciated!

@jcreamer898
Copy link
Contributor

I'll have a look. —
Sent from Mailbox

On Sat, Jul 5, 2014 at 12:38 PM, Douglas Neiner [email protected]
wrote:

The AmplifyJS Nuget package has been needing to be updated with the latest code for a while. This request adds the nuspec file into Source control (as well as the associated readme) and maps the built output of Amplify to match the existing Nuget structure. The only new addition is the amplify folder with individual components inside. The finished package files look like this:

/content
  /Scripts
    /amplify
       amplify.core.js
       amplify.core.min.js
       amplify.request.js
       amplify.request.min.js
       amplify.store.js
       amplify.store.min.js
    amplify-vsdoc.js
    amplify.js
    amplify.min.js
    GPL-LICENSE.txt
    MIT-LICENSE.txt
    README.txt

After discussing with @elijahmanor I opted to not put the amplify.js and amplify.min.js files in the /amplify directory so those upgrading from an older version of the package wouldn't have trouble with the files moving.
If @jcreamer898 or anyone else with more experience in .NET and Nuget could chime in on this commit, it would be appreciated!
You can merge this Pull Request by running:
git pull https://github.com/appendto/amplify nuget
Or you can view, comment on it, or merge it online at:
#100
-- Commit Summary --

@dcneiner
Copy link
Contributor Author

dcneiner commented Jul 5, 2014

Thanks @jcreamer898 – it can wait until next week too… Also, it will only work if you have used anvil to build the output files first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants