Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #22, Private key and seed can be sent to the node #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue #22, Private key and seed can be sent to the node #23

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 24, 2018

See issue #22.
Note: I've never used typescript before. It works, but may need some changes.

@rawrmaan
Copy link
Collaborator

rawrmaan commented Apr 3, 2018

Love this idea--just need to add buffer to the package.json in order support non-node.js environments. I'll try to get to testing this soon.

@rawrmaan
Copy link
Collaborator

Since v11/v12 are now out, this PR can no longer be merged unless it is updated to support creating state blocks.

@roccomuso
Copy link

this module make no sense without this PR merged, that address a major security concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants