Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3 proof uploading failure #212

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

jayeclark
Copy link
Collaborator

Signed-off-by: Jay Clark [email protected]

Pull-Request for paretOS

Description

Updates AWSAmplify configuration to fix bucket name and add region, fixes deprecated imports & syntax. (I also fixed the bucket policy on the back end which was the majority of the work here.)

Proof of daily achievements now uploads to S3 as intended and is available for users to download! Currently it just downloads rather than being displayed, so, I may open a ticket for that refinement.

Relates to

Reviewers

Screenshots / other info

Screenshot showing proof link and downloaded proof.
Screen Shot 2022-04-20 at 12 26 16 PM

@mikhael28 mikhael28 merged commit 2b1fc06 into mikhael28:main Apr 20, 2022
@jayeclark jayeclark deleted the fix/aws-region-error branch April 30, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Daily Achievement Proof does not upload to S3 Bucket - "Error: Region is missing"
2 participants