Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed idempotency when default user replaced #12 #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikolyabb
Copy link

@nikolyabb nikolyabb commented Apr 22, 2018

To solve #12

  1. Changed sudoers privilege grant from /etc/sudoers to /etc/sudoers.d/username
  2. Delete user step moved from handlers to tasks/main.yml
  3. Added check if replacement user exist

Hope it will also help with #10

@mikolak-net
Copy link
Owner

This is pending setting up a proper CI env.

Copy link
Owner

@mikolak-net mikolak-net left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, terribly sorry for taking so long to get around to this.

Looks good, but for one minor thing.

@@ -14,6 +14,18 @@
- import_tasks: setup_replace_user.yml
when: raspi_config_replace_user['name'] != None

- name: Verify if replace_user exists
stat:
path: "/etc/sudoers.d/{{ raspi_config_replace_user['name'] }}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark - shouldn't this also include the pseudo-priority prefix, in line with how the directory is organized by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants