[SARC-328] Implémenter les alertes : Nombre de jobs CPU/GPU (actives ou inactives) sur un cluster sur une période X #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoraptor
force-pushed
the
sarc-328
branch
from
5c400d4
to
0144f20
Compare
|
Prêt à reviewer ! |
…ou inactives) sur un cluster sur une période X
…use full dataframe to check warnings Add supplementary tests
notoraptor
force-pushed
the
sarc-328
branch
from
7b6ff2f
to
5953724
Compare
|
Rebased with master |
- Remove `exclude` parameter and use only `cluster_names` for both adding and excluding clusters from checking.
nurbal
reviewed
Sep 17, 2024
nurbal
reviewed
Sep 17, 2024
| .count() | ||
| ) | ||
| # Compute cluster usage: number of jobs per cluster per timestamp | ||
| f_stats["jobs_per_cluster"] = f_stats["job_id"] / len(cluster_names) |
There was a problem hiding this comment.
Hmmm donc le calcul des valeurs statistiques (moyenne, écart-type) est pour l'ensemble des clusters, et pas cluster par cluster, si je comprends bien ? Je pense que ce qu'on voulait c'est des valeurs statistiques pour chaque cluster, indépendemment. (Mais je me trompe peut-être dans la lecture du code)
There was a problem hiding this comment.
En effet, les statistiques sont actuellement calculées sur l'ensemble des clusters.
Je vais modifier le code pour les calculer cluster par cluster à travers les jours.
nurbal
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nurbal !
NB basée sur la PR pour SARC-327 #127 à merger en premier !