[SARC-330] Implémenter les alertes : Proportion de jobs GPU avec stats prometheus spécifique aux GPUs sur un noeud donné plus bas qu’un threshold X #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notoraptor
force-pushed
the
sarc-330
branch
from
273ef0e
to
5fdac84
Compare
…s prometheus spécifique aux GPUs sur un noeud donné plus bas qu’un threshold X
notoraptor
force-pushed
the
sarc-330
branch
from
5fdac84
to
d47872f
Compare
nurbal
reviewed
Nov 18, 2024
| min_jobs_per_group: Optional[Union[int, Dict[str, int]]] = None, | ||
| nb_stddev=2, | ||
| with_gres_gpu=False, |
There was a problem hiding this comment.
Ce nouveau parametre n'est pas testés dans test_check_prometheus_scraping_stats, et donc on teste uniquement le cas des jobs CPU.
nurbal
reviewed
Nov 18, 2024
| @@ -81,24 +91,41 @@ def check_prometheus_stats_occurrences( | |||
| clip_time = True | |||
| df = load_job_series(start=start, end=end, clip_time=clip_time) | |||
|
|
|||
| # Parse minimum_runtime, and select only jobs where | |||
| # elapsed time >= minimum runtime and allocated.gres_gpu == 0 | |||
There was a problem hiding this comment.
... d'ailleurs avant on ignorait les jobs GPU, on dirait bien ^^
nurbal
approved these changes
Nov 19, 2024
| @@ -175,3 +201,43 @@ def check_prometheus_stats_occurrences( | |||
| logger.warning( | |||
| f"[{cluster_name}] no Prometheus data available: no job found" | |||
| ) | |||
|
|
|||
|
|
|||
| def check_prometheus_stats_for_gpu_jobs( | |||
There was a problem hiding this comment.
... au temps pour moi, je n'étais pas bien réveillé. test_check_prometheus_stats_for_gpu_jobs teste bien les GPU à travers l'appel à check_prometheus_stats_for_gpu_jobs. Pas vraiment un test unitaire, mais c'est ok pour moi :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nurbal ! Prêt pour une review !