Redirect when not connected #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to handle the login information
notoraptor
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
@soline-b C'est bon pour moi ! J'ai testé en local, on est bien redirigé vers la page d'accueil si on consulte les autres pages sans être connecté. Vérifié pour /jobs/, jobs/dashboard, jobs/interactive, /settings, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request relates to ticket CW-402.
When trying to access to some pages (for instance
/jobs/search) unlogged, a anonymous user was not redirected to the login page, but the page was displayed anyway. As the anonymous user has no access, this did not end up with a leak of data, but could lead to some errors (for instance when trying to change web settings of the user) and is counter-intuitive for the user experience.