Don't use schema_overrides anymore in ptabler

[dbolotin]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: de0768e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
@platforma-open/milaboratories.software-ptabler	Minor
@platforma-sdk/workflow-tengo	Patch
@milaboratories/pl-middle-layer	Patch
@milaboratories/milaboratories.monetization-test.workflow	Patch
@milaboratories/milaboratories.ui-examples.workflow	Patch
@milaboratories/milaboratories.pool-explorer.workflow	Patch
@platforma-sdk/test	Patch
@milaboratories/milaboratories.monetization-test	Patch
@milaboratories/milaboratories.ui-examples	Patch
@milaboratories/milaboratories.pool-explorer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @dbolotin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the data reading process in "ptabler" by discontinuing the use of "schema_overrides" during initial data scanning. Instead, it implements a more reliable post-read casting mechanism using Polars' "with_columns" and "cast" expressions, addressing unreliability issues with "schema_overrides".

Highlights

• Deprecation of schema_overrides: The "schema_overrides" parameter is no longer passed to Polars scan commands during data ingestion, as it was found to be unreliable.
• Introduction of Post-Scan Casting: Column type enforcement is now performed after the initial data scan. This involves iterating through defined column types and applying "cast" expressions using "pl.col().cast()" to the "LazyFrame".
• Configurable Casting Strictness: The post-scan casting now dynamically determines its strictness based on the "ignore_errors" flag. If "ignore_errors" is true, non-strict casting is applied; otherwise, strict casting is used.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request replaces the use of schema_overrides in polars scan operations with post-read casting, which is a sensible change given the potential unreliability of schema_overrides. The implementation correctly performs casting after the scan and uses the ignore_errors flag to control casting strictness. I have one suggestion to improve the readability of the logic that determines this strictness.