Allow passing chrome binary path via environment variable #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows cuic to find the chrome binary on Systems that do not follow any standard file system hierarchy.
|
Addendum: Feel free to change the variable name. |
|
Talk about bad timing… just now I read in the docs that it's actually possible to pass the binary. This might still be useful, but much less necessary than I thought it would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been exploring cuic on NixOS, which doesn't adhere to the standard file system hierarchy, making the hard-coded paths in
cuic.chromeproblematic. This PR introduces the ability to specify the path to the Chrome binary using an environment variable.This feature isn't just beneficial for NixOS users. Allowing users to point to a specific Chrome binary can be useful for testing against upcoming, unreleased versions of Chrome or pinning a specific version for consistent testing (e.g., using the Nix package manager on MacOS).