[Not a bug] Modal event propagation #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set a versioning label of either |
This reverts commit 3805c7b.
thomaslarsson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some trial and error, we found out that the event propagation (naturally) only happened when the MdModal was a child element of an element with a click-handler. A real life problem happened due to this as well, even though the modal was moved in the DOM using a portal. Why this works is beyond the scope of this issue.
Similar problems can be solved by moving the component outside the problematic click handler. Another solution is to wrap the Modal element itself with a handler that stops propagation upwards towards the problematic parent.
The behavior is not a bug itself with the component library. I'm therefore closing this issue.