Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove cursor-pointer from MdRadioButton where it is not clickable and add pointer to label #185

Merged
merged 9 commits into from
Oct 15, 2024
Merged

fix: Remove cursor-pointer from MdRadioButton where it is not clickable and add pointer to label #185

merged 9 commits into from
Oct 15, 2024

Conversation

aurorascharff
Copy link
Contributor

@aurorascharff aurorascharff commented Oct 15, 2024 •
edited
Loading

Describe your changes

When hovering MdRadioButton, the area between the label and the check_area has cursor-pointer while not being clickable. Remove cursor pointer here and adjust area for label to become underlined in the same area. Add cursor pointer to label.

Oct-15-2024 10-11-05

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is css-file added to packages/css/index.css?

@github-actions GitHub Actions
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff aurorascharff marked this pull request as ready for review October 15, 2024 07:28
@aurorascharff aurorascharff requested a review from a team as a code owner October 15, 2024 07:28
@aurorascharff aurorascharff changed the title fix: Make MdRadioButton clickable everywhere it has cursor-pointer fix: Remove cursor-pointer from MdRadioButton where it is not clickable Oct 15, 2024
@aurorascharff aurorascharff added minor and removed patch labels Oct 15, 2024
@aurorascharff aurorascharff changed the title fix: Remove cursor-pointer from MdRadioButton where it is not clickable fix: Remove cursor-pointer from MdRadioButton where it is not clickable and add pointer to label Oct 15, 2024
@aurorascharff aurorascharff merged commit 7367f10 into main Oct 15, 2024
3 checks passed
@aurorascharff aurorascharff deleted the fix-radiobutton-click-area branch October 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaslarsson thomaslarsson thomaslarsson approved these changes

@kajsaeggum kajsaeggum kajsaeggum approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aurorascharff @thomaslarsson @kajsaeggum