Add "use client" to all potentially interactive components to enable support for Server Components #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove "old" radix-ui combobox testing
Fixed issue where focus shifted to input field after selecting item with keyboard. Possibly also fixed weird focus border on zoomed out screens?
fix disabled text colors
z-index, defaultOptions, dropdownHeight, prefixIcon, some colors and replace matchSorter with regular array.filter (to see if it improves performance)
…support for Server Components
…ljodir/md-components into add-use-client-react19
|
Please set a versioning label of either |
Adjust input padding to accommodate for no icon
…ljodir/md-components into add-use-client-react19
… add-use-client-react19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add "use client" to all potentially interactive components to enable support for Server Components. Without this, the project using i.e Next.js needs to make wrapper components for all the interactive components coming from md-components.
After adding ariakit in feature/radix-ui (pending PR), errors would be thrown regardless due to context not working on the server.
Checklist before requesting a review
major,minororpatch)stories-folder?packages/react/index.tsx?packages/css/index.css?