Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading state and indicator to button components #233

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ohp-inmeta
Copy link
Contributor

Describe your changes

Add loading state and indicators to MdButton and MdIconButton
This indicator replaces right or top icon for MdButton and main icon for MdIconButton

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is README-file for CSS documentation created and added to the story?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is CSS-file added to packages/css/index.css?

@ohp-inmeta ohp-inmeta requested a review from a team as a code owner February 20, 2025 13:35
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ohp-inmeta ohp-inmeta merged commit d49dc42 into main Feb 21, 2025
3 checks passed
@ohp-inmeta ohp-inmeta deleted the 231-button-loading-states branch February 21, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MdButton and MdIconButton should have a loading state that enables a MdLoadingSpinnerIcon
2 participants