Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust chips focus #240

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Adjust chips focus #240

merged 2 commits into from
Feb 27, 2025

Conversation

ohp-inmeta
Copy link
Contributor

@ohp-inmeta ohp-inmeta commented Feb 26, 2025

Describe your changes

Add inner outline for focused selected chips
Updated gitignore

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is README-file for CSS documentation created and added to the story?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is CSS-file added to packages/css/index.css?

Add inner outline for focused selected chips
Updated gitignore
@ohp-inmeta ohp-inmeta requested a review from a team as a code owner February 26, 2025 08:16
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

@aurorascharff
Copy link
Contributor

aurorascharff commented Feb 26, 2025

Ser ut som focus state på ikke aktiv ikke fungerer i henhold til skisse, denne er i fokus men ser lik ut. Evt bare en hvit border som er litt tykkere.

Google Chrome 2025-02-26 10 47 03

@ohp-inmeta
Copy link
Contributor Author

Ser ut som focus state på ikke aktiv ikke fungerer i henhold til skisse, denne er i fokus men ser lik ut. Evt bare en hvit border som er litt tykkere.

Google Chrome 2025-02-26 10 47 03

Dette er pga 90% zoom, slik som en tidligere sak. Funker fint på 100% zoom. Kan se om det er noen enkel måte å løse det på.

@aurorascharff
Copy link
Contributor

aurorascharff commented Feb 26, 2025

-- Ola derpa kommentaren her... Skulle quote, men endte opp med å edit, sorry :D

Figma dictates 3px outline on focus
@ohp-inmeta
Copy link
Contributor Author

@aurorascharff Oppdaterte outline ved fokus til 3px siden det er det som er i Figma. Da fungerer det ved 90% zoom også.

Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nydelig!

@ohp-inmeta ohp-inmeta merged commit d5eabfb into main Feb 27, 2025
3 checks passed
@ohp-inmeta ohp-inmeta deleted the feature/232-chips-focus-styles branch February 27, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve focus on active state of chips to meet WCAG 2.1 contrast requirements
2 participants