Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes both the checkbox and checkbox group components disabled behavior #251

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fixes both the checkbox and checkbox group components disabled behavior #251

merged 1 commit into from
Mar 7, 2025

Conversation

xRiku
Copy link
Contributor

@xRiku xRiku commented Mar 7, 2025

Describe your changes

Added the disabled attribute that was missing in MdCheckbox, closes #248

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)
  • If new component: Is story for component created in stories-folder?
  • If new component: Is README-file for CSS documentation created and added to the story?
  • If new component: Is tsx-file import added to packages/react/index.tsx?
  • If new component: Is CSS-file added to packages/css/index.css?

@xRiku xRiku requested a review from a team as a code owner March 7, 2025 12:57
@aurorascharff aurorascharff merged commit 4b6b3d3 into miljodir:main Mar 7, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurorascharff aurorascharff aurorascharff approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox is still checkable when disabled
2 participants
@xRiku @aurorascharff