Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select, multiselect & autocomplete styling fixes #94

Merged
merged 9 commits into from
Jan 30, 2024

Conversation

Jaanesen
Copy link
Contributor

Describe your changes

For all three components: MdSelect, MdMultiSelect and MdAutocomplete I have fixed the following:

  • labels can now be removed entirely, and padding will not be rendered.
  • "chevron" is rotated when the dropdown is expanded
  • size "small", is now the correct size, also in height.
  • Select and mulitselect now has a dropdownHeight attribute so the max-height of the dropdown can be customized
  • entire "box" of autocomplete is now clickable
  • minor styling adjustments across all three components to prevent border-jumping/moving on expansion and focus.

Checklist before requesting a review

  • I have performed a self-review and test of my code
  • I have added label to the PR (major, minor or patch)

@Jaanesen Jaanesen added the patch label Jan 30, 2024
@Jaanesen Jaanesen requested a review from a team as a code owner January 30, 2024 12:27
Copy link
Contributor

Please set a versioning label of either major, minor, or patch to the pull request.

Copy link
Contributor

@aurorascharff aurorascharff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@Jaanesen Jaanesen merged commit 24d2609 into main Jan 30, 2024
1 check passed
@Jaanesen Jaanesen deleted the MALIN-642-designsystem-md-select-sizing-fix branch January 30, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants