Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/magma free #1

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

[WIP] Feature/magma free #1

wants to merge 4 commits into from

Conversation

a-sevin
Copy link
Member

@a-sevin a-sevin commented Sep 27, 2020

This is a proposition to remove magma dependency (but still optional)

When I writing this PR, it's not compiling on ArchLinux but it does on CeontOS 8 (could be a bug of the arch gcc).
What's changing ?

  • cudacomppsinv uses CUDACOMP_magma_compute_SVDpseudoInverse_cli with USE_MAGMA=ON else CUDACOMP_cusolver_compute_SVDpseudoInverse_cli
  • there are 2 new CLI functions :
    • cudacomppsinv_magma for CUDACOMP_magma_compute_SVDpseudoInverse_cli
    • cudacomppsinv_cusolver for CUDACOMP_cusolver_compute_SVDpseudoInverse_cli

I also reworked cudacomp_types.h to be remove MAGMA functions calls.

@DasVinch
Copy link
Member

Thanks Arnaud. Note that if the speed is maintained (RT MVM: critical; SVDs: non critical but convenient), we have no problems with dropping magma altogether, to get rid of some #ifdefs.

@a-sevin a-sevin marked this pull request as draft September 28, 2020 17:37
@a-sevin a-sevin force-pushed the feature/magma-free branch from 43ad960 to d3eaeb8 Compare April 12, 2021 08:29
@gregwallan
Copy link

What is the status of removing the MAGMA dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants