Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch_cacao_dev.sh to remove missing patch #18

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

jaredmales
Copy link
Member

this is no longer needed, and the path file is removed.

this is no longer needed, and the path file is removed.
@drbitboy drbitboy closed this Sep 19, 2023
@jaredmales
Copy link
Member Author

why'd you close this @drbitboy ? This is causing an error on every attempt to do a fresh install.

@drbitboy drbitboy reopened this Sep 19, 2023
@drbitboy
Copy link
Collaborator

I closed it because it is only one statement, and you commented that it was no longer needed.

@jaredmales
Copy link
Member Author

oh, i meant "that patch is no longer needed", not "the PR is not longer needed"

@drbitboy
Copy link
Collaborator

the PR is the patch, and nought else.

@jaredmales
Copy link
Member Author

this PR is to remove the patch from the script, because what the patch was doing (removing a -llapacke line in a CMakeLists ) is no longer needed because that line was deleted permanently.

@drbitboy
Copy link
Collaborator

drbitboy commented Sep 19, 2023

d'Oh! Of course. Merge it.

However, even if we don't merge it, that patch command cannot cause a problem because it must exit with the success exit code, even when it issues a warning message. So there is no way that line can cause a fresh install to fail.

Jes' sayin.

@DasVinch DasVinch closed this Sep 20, 2023
@DasVinch DasVinch reopened this Sep 20, 2023
@DasVinch DasVinch merged commit 7f07325 into dev Sep 20, 2023
@DasVinch DasVinch deleted the jaredmales-patch-1 branch September 20, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants