Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PROCESSINFO_TRIGGERMODE_SEMAPHORE_PROP_TIMEOUTS and make it… #35

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

DasVinch
Copy link
Member

@DasVinch DasVinch commented Dec 5, 2024

… default for milk-streamFITSlog.

Adding triggermode 5, which is also a semaphore mode.

In triggermode PROCESSINFO_TRIGGERMODE_SEMAPHORE (==3), the TIMEOUT is caught and the overall computation is shunted into a continue;
In PROCESSINFO_TRIGGERMODE_SEMAPHORE_PROP_TIMEOUTS (==5), the timeout is willfully propagated, the execution of the loop iteration begins, and the timeout status can be checked in processinfo if need be. This actually emulates the old semaphore behavior when timeouts would propagate (by default every second) and click the AO chain unit after unit.

This fixes the following issues in logshim:

  • FITS cube is finalized and dumped upon stream timeout
  • FITS cube is finalized and dumped if saveON is set to False after the last frame

@oguyon foresee any pitfall?

@DasVinch DasVinch requested a review from oguyon December 5, 2024 06:43
@DasVinch
Copy link
Member Author

DasVinch commented Dec 5, 2024

FYI this branch is currently live on scexao5, not ported anywhere else yet.

@DasVinch DasVinch merged commit b3adb61 into dev Dec 11, 2024
3 of 4 checks passed
@DasVinch DasVinch deleted the vd/processtrigtimeout branch December 11, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant