Skip to content

Commit

Permalink
fix: remove legacy x/params and x/gov (#5)
Browse files Browse the repository at this point in the history
continued from #4

<!--
*** Please remove the following help text before submitting: ***

Pull requests without a rationale and clear improvement may be closed
immediately.

-->

<!--
Please provide clear motivation for your patch and explain how it
improves
initia user experience or initia developer experience
significantly:

* Any test improvements or new tests that improve coverage are always
welcome.
* All other changes should have accompanying unit tests (see
`src/test/`) or
functional tests (see `test/`). Contributors should note which tests
cover
modified code. If no tests exist for a region of modified code, new
tests
  should accompany the change.
* Bug fixes are most welcome when they come with steps to reproduce or
an
explanation of the potential issue as well as reasoning for the way the
bug
  was fixed.
* Features are welcome, but might be rejected due to design or scope
issues.
If a feature is based on a lot of dependencies, contributors should
first
  consider building the system outside of initia, if possible.
-->

<!--
Initia has a thorough review process and even the most trivial change
needs to pass a lot of eyes and requires non-zero or even substantial
time
effort to review. There is a huge lack of active reviewers on the
project, so
patches often sit for a long time.
-->
  • Loading branch information
hallazzang authored Jun 6, 2024
1 parent 6f28ee9 commit 64104f2
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 1,158 deletions.
13 changes: 0 additions & 13 deletions x/icacallbacks/types/params.go
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@
package types

import (
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
"gopkg.in/yaml.v2"
)

var _ paramtypes.ParamSet = (*Params)(nil)

// ParamKeyTable the param key table for launch module
func ParamKeyTable() paramtypes.KeyTable {
return paramtypes.NewKeyTable().RegisterParamSet(&Params{})
}

// NewParams creates a new Params instance
func NewParams() Params {
return Params{}
Expand All @@ -22,11 +14,6 @@ func DefaultParams() Params {
return NewParams()
}

// ParamSetPairs get the params.ParamSet
func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
return paramtypes.ParamSetPairs{}
}

// Validate validates the set of params
func (p Params) Validate() error {
return nil
Expand Down
16 changes: 0 additions & 16 deletions x/records/types/params.go
Original file line number Diff line number Diff line change
@@ -1,16 +1,5 @@
package types

import (
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
)

var _ paramtypes.ParamSet = (*Params)(nil)

// ParamKeyTable the param key table for launch module
func ParamKeyTable() paramtypes.KeyTable {
return paramtypes.NewKeyTable().RegisterParamSet(&Params{})
}

// NewParams creates a new Params instance
func NewParams() Params {
return Params{}
Expand All @@ -21,11 +10,6 @@ func DefaultParams() Params {
return NewParams()
}

// ParamSetPairs get the params.ParamSet
func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
return paramtypes.ParamSetPairs{}
}

// Validate validates the set of params
func (p Params) Validate() error {
return nil
Expand Down
8 changes: 0 additions & 8 deletions x/stakeibc/types/codec.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/msgservice"
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
)

func RegisterCodec(cdc *codec.LegacyAmino) {
Expand All @@ -19,8 +18,6 @@ func RegisterCodec(cdc *codec.LegacyAmino) {
cdc.RegisterConcrete(&MsgAddValidators{}, "stakeibc/AddValidators", nil)
cdc.RegisterConcrete(&MsgChangeValidatorWeights{}, "stakeibc/ChangeValidatorWeights", nil)
cdc.RegisterConcrete(&MsgDeleteValidator{}, "stakeibc/DeleteValidator", nil)
cdc.RegisterConcrete(&AddValidatorsProposal{}, "stakeibc/AddValidatorsProposal", nil)
cdc.RegisterConcrete(&ToggleLSMProposal{}, "stakeibc/ToggleLSMProposal", nil)
cdc.RegisterConcrete(&MsgRestoreInterchainAccount{}, "stakeibc/RestoreInterchainAccount", nil)
cdc.RegisterConcrete(&MsgUpdateValidatorSharesExchRate{}, "stakeibc/UpdateValidatorSharesExchRate", nil)
cdc.RegisterConcrete(&MsgCalibrateDelegation{}, "stakeibc/CalibrateDelegation", nil)
Expand Down Expand Up @@ -52,11 +49,6 @@ func RegisterInterfaces(registry cdctypes.InterfaceRegistry) {
&MsgUpdateHostZoneParams{},
)

registry.RegisterImplementations((*govtypes.Content)(nil),
&AddValidatorsProposal{},
&ToggleLSMProposal{},
)

msgservice.RegisterMsgServiceDesc(registry, &_Msg_serviceDesc)
}

Expand Down
141 changes: 0 additions & 141 deletions x/stakeibc/types/gov.go

This file was deleted.

Loading

0 comments on commit 64104f2

Please sign in to comment.