Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ICA liquid staking modules #2

Merged
merged 35 commits into from
May 29, 2024
Merged

feat: add ICA liquid staking modules #2

merged 35 commits into from
May 29, 2024

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented May 10, 2024 •
edited
Loading

Closes: MILK-10

@hallazzang hallazzang self-assigned this May 10, 2024
@RiccardoM RiccardoM force-pushed the hallazzang/add-ica-liquid-staking-2 branch from e327176 to bb68592 Compare May 10, 2024 19:55
@RiccardoM RiccardoM force-pushed the hallazzang/add-ica-liquid-staking-2 branch from bb68592 to 9bbb903 Compare May 10, 2024 20:43
hallazzang and others added 18 commits May 16, 2024 05:09
@hallazzang
fix: change base denom to umilk
2fa6424
@hallazzang
fix: fix reflection in stakeibc GetParams
eda56e6
@hallazzang
fix: change address prefix to init
5bcd13f
@beer-1 @hallazzang
add timestamp default cp
6300341 
(cherry picked from commit e7aa290)
@beer-1 @hallazzang
bump slinky to latest and use hash strategy
1f6610c 
(cherry picked from commit 3a13dcd)
@beer-1 @hallazzang
fix to prevent ibc packet stuck
2fee37a 
(cherry picked from commit aa7be7b)
@hallazzang
fix: use legacy param subspace
776f270
@hallazzang
fix: ignore ratelimit proto annotation warning
d9c8277
@hallazzang
fix: setup ibc stacks correctly
2560a36
@hallazzang
fix: move keeper initializations above ibc stack setup
c9083dd
@hallazzang
fix: adjust keeper initialization order
978e09c
@hallazzang
fix: fix keeper initialization order again
d894ed7
@hallazzang
fix: add signer annotations
73b7f4e
@hallazzang
fix: set empty stakeibc hooks to prevent panic
6f8d337
@hallazzang
chore: set STRIDE_EPOCH duration to 1 minute
262c55c
@hallazzang
fix: fix typo
e16f3ba
@hallazzang
fix: set StrideEpochsPerDayEpoch correctly
d5ae175
@hallazzang
fix: use mstaking instead of Cosmos SDK staking
f22ebac
@hallazzang hallazzang marked this pull request as ready for review May 27, 2024 08:06
RiccardoM
RiccardoM reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing building errors in both the lint and the test workflow. Is it possible to fix them so that we can have a codebase that has all the CI working properly?

@hallazzang hallazzang requested review from RiccardoM and rustcandy May 28, 2024 08:48
@hallazzang
Copy link
Contributor Author

@RiccardoM Fixed lint workflow issues.

@RiccardoM RiccardoM merged commit 89c79a9 into main May 29, 2024
15 checks passed
@RiccardoM RiccardoM deleted the hallazzang/add-ica-liquid-staking-2 branch May 29, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiccardoM RiccardoM RiccardoM approved these changes

@manu0466 manu0466 manu0466 approved these changes

@rustcandy rustcandy Awaiting requested review from rustcandy

Assignees

@hallazzang hallazzang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hallazzang @manu0466 @RiccardoM @rustcandy @beer-1