Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply Cosmos SDK v0.50 conventions #208

Merged
merged 4 commits into from
Dec 11, 2024

Conversation

hallazzang
Copy link
Contributor

@hallazzang hallazzang commented Nov 29, 2024

Description

The main changes are:

  • Use Walk() instead of old iterator-based approaches where applicable
  • Return an error only instead of a bit of redundant (T, bool error)
  • Remove unused storeService references in keepers

This PR introduces no state-breaking changes but note that merging this PR is not urgent.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@hallazzang hallazzang self-assigned this Nov 29, 2024
@hallazzang hallazzang marked this pull request as ready for review December 2, 2024 06:03
@RiccardoM RiccardoM changed the title refactor: apply Cosmos SDK v0.50 conventions chore(refactor): apply Cosmos SDK v0.50 conventions Dec 6, 2024
@RiccardoM RiccardoM changed the title chore(refactor): apply Cosmos SDK v0.50 conventions refactor: apply Cosmos SDK v0.50 conventions Dec 6, 2024
this is the common convention and the caller is still able to check if
the error was collections.ErrNotFound
suite.Require().NoError(err)
suite.Require().True(found)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add back these tests by changing them to make sure the returned error is ErrNotFound? We might need to create a new testutils method to do this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err == nil means the pool was found, so we don't need further tests after suite.Require().NoError(err). I added suite.Require().ErrorIs(err, collections.ErrNotFound) to where we originally had suite.Require().False(found) tests.

x/operators/keeper/alias_functions.go Outdated Show resolved Hide resolved
x/operators/keeper/genesis.go Outdated Show resolved Hide resolved
x/restaking/keeper/grpc_query.go Outdated Show resolved Hide resolved
x/restaking/keeper/grpc_query.go Outdated Show resolved Hide resolved
@hallazzang hallazzang requested a review from RiccardoM December 10, 2024 08:38
@RiccardoM RiccardoM merged commit 1ffe639 into main Dec 11, 2024
17 checks passed
@RiccardoM RiccardoM deleted the hallazzang/apply-sdk50-convention branch December 11, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants