-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: apply Cosmos SDK v0.50 conventions #208
Conversation
this is the common convention and the caller is still able to check if the error was collections.ErrNotFound
83a96ff
to
ce596fc
Compare
suite.Require().NoError(err) | ||
suite.Require().True(found) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add back these tests by changing them to make sure the returned error is ErrNotFound
? We might need to create a new testutils
method to do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
err == nil
means the pool was found, so we don't need further tests after suite.Require().NoError(err)
. I added suite.Require().ErrorIs(err, collections.ErrNotFound)
to where we originally had suite.Require().False(found)
tests.
Description
The main changes are:
Walk()
instead of old iterator-based approaches where applicable(T, bool error)
storeService
references in keepersThis PR introduces no state-breaking changes but note that merging this PR is not urgent.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change